You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@ziw-liu@talonchandler This code is likely used in PTI reconstruction - we need to filter permittivity tensor components individually for averaging. It looks like all the scalar simulation and reconstruction algorithms are now implemented with pytorch. Let's touch base in person on the status of vector simulation/reconstruction code, and how to get to pytorch implementation.
I'm going to keep this issue open, because I still think we should migrate from the custom waveorder.util.uniform_filter_2D to a scipy implementation. @mattersoflight is correct that this function is used by the PTI reconstruction, so this migration can happen alongside the PTI migration to torch, see #142.
I've also opened a new issue for discussion of GPU support #144. For now, the README on main is still accurate since there are still PTI parts of the code that utilize CuPy. I think we can remove CuPy (and update the README) when everything has moved to torch, see #143.
waveorder.util.uniform_filter_2D
currently uses a custom set of numerical operations to reimplementscipy.ndimage.uniform_filter
on GPU.This should be replaced by calling the CuPy API directly.
The text was updated successfully, but these errors were encountered: