Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Divide by zero during phase normalization #140

Open
talonchandler opened this issue Jul 25, 2023 · 0 comments
Open

Divide by zero during phase normalization #140

talonchandler opened this issue Jul 25, 2023 · 0 comments
Assignees
@talonchandler

Comments

@talonchandler
Copy link
Collaborator

talonchandler commented Jul 25, 2023 •
edited
Loading

recOrder tests surfaced the following warning.

recOrder/tests/cli_tests/test_reconstruct.py::test_reconstruct
  /Users/talon.chandler/waveorder/waveorder/util.py:711: RuntimeWarning: invalid value encountered in divide
    img_norm_stack[i] = img_stack[i] / uniform_filter(

This section is used by the isotropic_thin_3d reconstruction during normalization before reconstruction. This division was copied directly from pre-alg-dev code, and these reconstructions are passing our qualitative tests and I'm not concerned about deep problems here.

This issue is related to #88. Edit: uniform_filter is from scipy while uniform_filter_2D is a custom implementation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@talonchandler talonchandler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@talonchandler