-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Append channels via CLI calls #454
Conversation
Codecov Report
@@ Coverage Diff @@
## main #454 +/- ##
========================================
+ Coverage 8.83% 9.45% +0.61%
========================================
Files 29 29
Lines 4561 4592 +31
========================================
+ Hits 403 434 +31
Misses 4158 4158
|
This appending channels is also something that I was battling with mantis, especially after the registration as well. I have found that appending is tricky when the process of appending crashes ( for whatever reason, you accidentally close the terminal, end the process,etc) then if you try to restart the appending since the channel name already exists it will fail. I was running both separately to make sure I had successful reconstructions/deskewing and then appending together. Is there a an easier way to cleanup or to re-append? |
Thank you @talonchandler for implementing cli call for appending multiple reconstructed channels. I have tested this on the dataset from Hunter in this folder and it is working well. |
I also use the iohub code and it's relatively fast. |
Thanks for testing @Soorya19Pradeep! @Soorya19Pradeep and I just discussed our next steps, and we agreed that:
|
Before this PR:
This pair of CLI calls
would overwrite the first phase reconstruction, resulting in a DAPI-only reconstruction.
After this PR:
The same CLI calls result in two channels in
output.zarr
as expected.