Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding all locales to Docker #3673

Merged
merged 3 commits into from
May 25, 2024

Conversation

ma-wenqian
Copy link
Contributor

Fixed 'Server failed to set locale to' error by adding all locales.

@ma-wenqian
Copy link
Contributor Author

ma-wenqian commented May 21, 2024

The missing locales caused the following issues.
#3615
#80
#3642

By installing locales-all, not locales, we can easily solve this problem.

@jberanek
Copy link
Member

How much bigger does this make the container image?

@jberanek
Copy link
Member

Also a minor nit-pick, I'd prefer if the PR didn't remove the final linefeed from the changed files.

@ma-wenqian
Copy link
Contributor Author

After installing all locales, the image becomes around 200MB bigger.

Copy link
Member

@jberanek jberanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jberanek jberanek merged commit 178223d into meeting-room-booking-system:main May 25, 2024
1 check failed
villeristi pushed a commit to villeristi/rks-calendar that referenced this pull request Jun 6, 2024
* Fixed 'Server failed to set locale to' error by adding all locales

* Update Dockerfile

* Update Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants