Fix potential type error

meeting-room-booking-system · Apr 24, 2024 · 53ad0fd · 53ad0fd
1 parent d84ec3e
commit 53ad0fd
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/web/lib/MRBS/Session/SessionWithLogin.php b/web/lib/MRBS/Session/SessionWithLogin.php
@@ -153,7 +153,8 @@ protected function getValidUser(
     #[\SensitiveParameter]
     ?string $password) : string
   {
-    if (($valid_username = auth()->validateUser($this->form['username'], $this->form['password'])) === false)
+    if (!isset($this->form['password']) ||
+        (($valid_username = auth()->validateUser($this->form['username'], $this->form['password'])) === false))
     {
       $this->authGet($this->form['target_url'], $this->form['returl'], get_vocab('unknown_user'));
       exit(); // unnecessary because authGet() exits, but just included for clarity