Simplify code

meeting-room-booking-system · Sep 3, 2023 · 2786a23 · 2786a23
1 parent b397e37
commit 2786a23
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/web/lib/MRBS/Auth/AuthPop3.php b/web/lib/MRBS/Auth/AuthPop3.php
@@ -41,8 +41,6 @@ public function validateUser(
   {
     global $pop3_host, $pop3_port;
 
-    $match = array();
-    $shared_secret = '';
     $all_pop3_hosts = array();
     $all_pop3_ports = array();
 
@@ -114,7 +112,7 @@ public function validateUser(
       }
 
       // If we have a shared secret then try APOP
-      if ($shared_secret)
+      if (isset($shared_secret) && ($shared_secret !== ''))
       {
         $md5_token = md5("$shared_secret$pass");
         $auth_string = "APOP $user $md5_token\r\n";