Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Engine(-Twitter),Frontend: avoid Close warning dialog (closes: #1093) #256

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Engine(-Twitter),Frontend: avoid Close warning dialog (closes: #1093) #256

wants to merge 2 commits into from

Commits on Nov 17, 2020

  1. Frontend: rename method in ChatViewSyncManager, to follow convention 

    Methods that start with "On" are normally the ones that get
called because they got subscribed to some event. In this
case, this method is the one in charge of raising that event
so to make it a bit less confusing, let's rename it to have
the "Raise" prefix instead of "On".
    @knocte
    knocte committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    9fad42e View commit details
    Browse the repository at this point in the history

  2. Engine(-Twitter),Frontend: avoid Close warning dialog (closes: #1093) 

    There are some protocols, like Twitter, in which there are no
consequences from disconnecting from the server: no unavailable
status is shown to our contacts, and no chat buffers will be
lost because all the info resides server-side. For these, there
is not really any point in warning the user about current open
chats when she intends to close the connection, so let's
whitelist Twitter in this way to avoid the pointless dialog.
    @knocte
    knocte committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    41b248b View commit details
    Browse the repository at this point in the history