Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ath fix edit user #628

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Ath fix edit user #628

merged 7 commits into from
Aug 22, 2024

Conversation

spointu
Copy link
Contributor

@spointu spointu commented Aug 22, 2024

No description provided.

xdri3n added 5 commits June 13, 2024 17:18
@xdri3n
(user) Fix display mail and phone on view list user
6c669fa 
We no longer saw the display of the email or the telephone number.

If several telephone numbers for a user are displayed with a line break
@xdri3n
First ever Medulla easteregg
93bce90
@xdri3n
(user) Fix user editing
2e5b3d2 
Empty strings were not sent to the xmlrpc function which did not allow the updating of last name, first name and telephone number information.
@xdri3n
(user) Refactoring display add or edit user
779c7e3 
We have deleted several fields that have become obsolete.

We have passed the choice of the secondary group to exeprt view only.
@xdri3n @neoclust
(user) Fix editing user mail, mobile, title
ac21b41 
Some attributes were not updated
(user) Fix: Update $arrParam["value"] assignment
(user) Fix Handle stripslashes if $attrval is an array
(user) Fix creating the LDAP entry
Remove byte literals from LDAP entries for cn and displayName
Correction of the management of telephone numbers
@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Aug 22, 2024 •
edited
Loading

🧙 Sourcery has finished reviewing your pull request!

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

sourcery-ai[bot]
sourcery-ai bot reviewed Aug 22, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

deepsource-autofix bot and others added 2 commits August 22, 2024 14:16
@deepsource-autofix
style: format code with Black and PHP CS Fixer
523b800 
This commit fixes the style issues introduced in ac21b41 according to the output
from Black and PHP CS Fixer.

Details: #628
@spointu
Merge branch 'integration' into ath-fix-edit-user
499d358
@spointu spointu merged commit ed89c08 into integration Aug 22, 2024
1 of 5 checks passed
@spointu spointu deleted the ath-fix-edit-user branch August 22, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spointu @xdri3n