Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Golang version v1.23 and Ginkgo #138

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

razo7
Copy link
Member

@razo7 razo7 commented Dec 4, 2024

Why we need this PR

Use newer Golang, Ginkgo, Medijk8s-common versions for new features, bug fixes, and regular improvements between versions.

Changes made

  • Bump Golang version (v1.20 -> v1.23) and Ginkgo (v2.14.0 -> v2.22.0)
  • Update OCP Version for Red Hat bundle community

Which issue(s) this PR fixes

Test plan

Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link
Contributor

openshift-ci bot commented Dec 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: razo7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 4, 2024
razo7 added 2 commits December 4, 2024 12:22
Also update OCP Version for Red Hat bundle community, and Medik8s common
Update module depedencices
@razo7 razo7 force-pushed the update-golang-1.23 branch from 5e33de7 to b75f473 Compare December 4, 2024 10:22
@razo7
Copy link
Member Author

razo7 commented Dec 4, 2024

/test 4.17-openshift-e2e

@mshitrit
Copy link
Member

mshitrit commented Dec 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 8, 2024
@razo7 razo7 marked this pull request as ready for review December 8, 2024 07:17
@openshift-ci openshift-ci bot requested review from clobrano and slintes December 8, 2024 07:17
@razo7
Copy link
Member Author

razo7 commented Dec 8, 2024

/retest

2 similar comments
@razo7
Copy link
Member Author

razo7 commented Dec 9, 2024

/retest

@razo7
Copy link
Member Author

razo7 commented Dec 9, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 280dbc2 into medik8s:main Dec 9, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants