This repository has been archived by the owner on Feb 3, 2022. It is now read-only.
Moved CSS location to media folder #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
| public function getCssDirectoryPath($store = null) | ||
| { | ||
|
|
||
| return Mage::getBaseDir('media') . $this->getCssPath($store); |
There was a problem hiding this comment.
Needs a trailing slash after media directory Mage::getBaseDir('media') . DS . $this->getCssPath($store);
|
Comments came as the result of some internal patches. Just making a note here so I can amend later. |
- Fixes issue where the directory path of the generated css file could be missing a directory slash. - Fixes issue where if a CDN is used, the generated file won't use the CDN URL. Fixes potential issue where SID parameters are included in the URL, and breaks file path.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5