BUG: PeriodArray subtraction returning wrong results (pandas-dev#46006)

me-kbs · Feb 16, 2022 · bf97db3 · bf97db3
1 parent d633abd
commit bf97db3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/doc/source/whatsnew/v1.5.0.rst b/doc/source/whatsnew/v1.5.0.rst
@@ -360,7 +360,7 @@ I/O
 
 Period
 ^^^^^^
--
+- Bug in subtraction of :class:`Period` from :class:`PeriodArray` returning wrong results (:issue:`45999`)
 -
 
 Plotting

diff --git a/pandas/core/arrays/period.py b/pandas/core/arrays/period.py
@@ -710,7 +710,7 @@ def _sub_period(self, other):
         self._check_compatible_with(other)
         asi8 = self.asi8
         new_data = asi8 - other.ordinal
-        new_data = np.array([self.freq * x for x in new_data])
+        new_data = np.array([self.freq.base * x for x in new_data])
 
         if self._hasna:
             new_data[self._isnan] = NaT

diff --git a/pandas/tests/extension/test_period.py b/pandas/tests/extension/test_period.py
@@ -25,9 +25,9 @@
 from pandas.tests.extension import base
 
 
-@pytest.fixture
-def dtype():
-    return PeriodDtype(freq="D")
+@pytest.fixture(params=["D", "2D"])
+def dtype(request):
+    return PeriodDtype(freq=request.param)
 
 
 @pytest.fixture
-Original file line number
+Diff line change
@@ Expand Up / @@ -360,7 +360,7 @@ I/O @@
     Period
     ^^^^^^
-    -
+    - Bug in subtraction of :class:`Period` from :class:`PeriodArray` returning wrong results (:issue:`45999`)
     -
     Plotting
@@ Expand Down @@