Skip to content

Commit

Permalink
fix broken Docker image build (pandas-dev#45889)
Browse files Browse the repository at this point in the history
* add "--no-build-isolation" to pip install

* add job "build_docker_dev_environment"

* Trigger Build

* fix wrong group name

* add step "Clean up dangling images"

* pin base image

* add newline at end of file

* always pull the latest version of the base image
  • Loading branch information
rendner authored Feb 17, 2022
1 parent 2541e00 commit 1bd193e
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 2 deletions.
24 changes: 24 additions & 0 deletions .github/workflows/code-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -156,3 +156,27 @@ jobs:
name: Benchmarks log
path: asv_bench/benchmarks.log
if: failure()

build_docker_dev_environment:
name: Build Docker Dev Environment
runs-on: ubuntu-latest
defaults:
run:
shell: bash -l {0}

concurrency:
# https://github.community/t/concurrecy-not-work-for-push/183068/7
group: ${{ github.event_name == 'push' && github.run_number || github.ref }}-build_docker_dev_environment
cancel-in-progress: true

steps:
- name: Clean up dangling images
run: docker image prune -f

- name: Checkout
uses: actions/checkout@v2
with:
fetch-depth: 0

- name: Build image
run: docker build --pull --no-cache --tag pandas-dev-env .
4 changes: 2 additions & 2 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM quay.io/condaforge/miniforge3
FROM quay.io/condaforge/miniforge3:4.11.0-0

# if you forked pandas, you can pass in your own GitHub username to use your fork
# i.e. gh_username=myname
Expand Down Expand Up @@ -45,4 +45,4 @@ RUN . /opt/conda/etc/profile.d/conda.sh \
&& cd "$pandas_home" \
&& export \
&& python setup.py build_ext -j 4 \
&& python -m pip install -e .
&& python -m pip install --no-build-isolation -e .

0 comments on commit 1bd193e

Please sign in to comment.