Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the JSX runtime types in RunOptions #2465

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix the JSX runtime types in RunOptions #2465

wants to merge 1 commit into from
+34 −48

Commits on Jul 16, 2024

  1. Fix the JSX runtime types in RunOptions 

    `@types/react` now has types for `react/jsx-runtime` and
`react/jsx-dev-runtime`. These types are not compatible with the types
provided by `hast-util-to-jsx-runtime`, which are used by MDX.

To resolve the issue, all runtime related options have been changed to
`unknown`. Since the user is supposed to pass in whatever JSX runtime
they imported, this should be sufficient.

This fixes several type errors. An outdated workaround has been removed
from the documentation.

Closes #2463
    @remcohaszing
    remcohaszing committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    facc3b4 View commit details
    Browse the repository at this point in the history