Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace alert in web api, scrollwidth property #34733

Merged
merged 6 commits into from
Jul 12, 2024

Conversation

evelinabe
Copy link
Contributor

Description

✍️ I have updated the example for the scrollWidth property. My intention was to only remove the alert function, but since the example code didn't follow the styling guides I grouped the code to code blocks and added some additional texts about the example as well.

Motivation

❓ They get a working example for scrollWidth, and the code will be easier to read when it is grouped in code blocks.

Additional details

🔗 #7566

Related issues and pull requests

See additional details

@evelinabe evelinabe requested a review from a team as a code owner July 9, 2024 11:07
@evelinabe evelinabe requested review from wbamberg and removed request for a team July 9, 2024 11:07
@github-actions github-actions bot added Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed labels Jul 9, 2024
Copy link
Contributor

github-actions bot commented Jul 9, 2024

Preview URLs

(comment last updated: 2024-07-12 15:40:48)

@Josh-Cena Josh-Cena mentioned this pull request Jul 9, 2024
26 tasks
@evelinabe evelinabe requested review from mdn-bot and a team as code owners July 12, 2024 04:50
@evelinabe evelinabe requested review from dipikabh, fred-wang, jpmedley and Elchi3 and removed request for a team July 12, 2024 04:50
@github-actions github-actions bot added the Content:CSS Cascading Style Sheets docs label Jul 12, 2024
@github-actions github-actions bot added size/m [PR only] 51-500 LoC changed and removed Content:Media Media docs Content:MathML MathML docs Content:Glossary Glossary entries Content:Games Games docs Content:Learn:JavaScript Learning area JavaScript docs Content:Firefox Content in the Mozilla/Firefox subtree Content:Learn:CSS Learning area CSS docs Content:Manifest system [PR only] Infrastructure and configuration for the project size/xl [PR only] >1000 LoC changed labels Jul 12, 2024
@evelinabe evelinabe requested a review from Josh-Cena July 12, 2024 07:49
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks a bunch!

@Josh-Cena Josh-Cena merged commit bf1d743 into mdn:main Jul 12, 2024
8 checks passed
@evelinabe evelinabe deleted the 7566-replace-alert-scrollwidth branch July 13, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants