Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CODEOWNERS - Firefox release notes #34724

Merged
merged 1 commit into from
Jul 11, 2024
Merged

CODEOWNERS - Firefox release notes #34724

merged 1 commit into from
Jul 11, 2024

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jul 9, 2024

Reviewing release notes is a priority for the MDN team employed by Mozilla (currently @dipikabh @hamishwillee @bsmth @pepelsbey @Rumyra @dletorey ) but not other members of the team. They might do it, but not to our timelines.

This proposes default assignment to other members of our team first. Note, that we might want to consider updating the group to include all members or having a new group https://github.com/orgs/mdn/teams/core-yari-content.

@hamishwillee hamishwillee requested a review from a team as a code owner July 9, 2024 00:52
@github-actions github-actions bot added system [PR only] Infrastructure and configuration for the project size/xs [PR only] 0-5 LoC changed labels Jul 9, 2024
Copy link
Contributor

@dipikabh dipikabh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hamishwillee. Incidentally, this is very much in line with what the team has been discussing during the GitHub work week.

Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this idea. Minor thing is there are only two dirs in mozilla:

./files/en-us/mozilla
├── add-ons
├── firefox
└── index.md

So something like this also looks good to me:

# Mozilla Firefox release notes
/files/en-us/mozilla @mdn/core-yari-content

# Mozilla Add-ons
/files/en-us/mozilla/add-ons/ @mdn/yari-content-mozilla-add-ons

I know Pranshu is working on this at the moment, but I'm +1 on it in general.

@bsmth
Copy link
Member

bsmth commented Jul 11, 2024

Thanks all, merging now and likely we'll have some tweaks to the dirs & teams soon.

@bsmth bsmth merged commit cbd1407 into main Jul 11, 2024
6 of 7 checks passed
@bsmth bsmth deleted the hamishwillee-codeowners-ff branch July 11, 2024 16:14
evelinabe pushed a commit to evelinabe/mdn-content that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/xs [PR only] 0-5 LoC changed system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants