Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve example for URL: searchParams property #34714

Merged
merged 4 commits into from
Jul 13, 2024

Conversation

Johngeorgesample
Copy link
Contributor

@Johngeorgesample Johngeorgesample commented Jul 8, 2024

Description

Rather than pretend we have a window with a given URL, let's codify what URL we're expecting by making it part of the example. I also replaced comments with console.logs to show the result of the .get()s

Motivation

I think it improves the readability of the example, but I'm open to feedback on how to make it even better!

@Johngeorgesample Johngeorgesample requested a review from a team as a code owner July 8, 2024 13:56
@Johngeorgesample Johngeorgesample requested review from wbamberg and removed request for a team July 8, 2024 13:56
@github-actions github-actions bot added Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed labels Jul 8, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Jul 8, 2024

Preview URLs

(comment last updated: 2024-07-13 22:51:17)

Johngeorgesample and others added 2 commits July 10, 2024 08:15
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Josh-Cena Josh-Cena merged commit b4470d4 into mdn:main Jul 13, 2024
8 checks passed
@Johngeorgesample Johngeorgesample deleted the improve-searchparams-example branch July 14, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants