Corrected shouldBeConsumedByChild logic for vertical scrolling #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
@filipkappa @marveluck @mdbootstrap any feedback or ETA for this being integrated? |
|
There is no PRs which have ever been accepted and the latest was about a year ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
Thank you very much for your contribution! Please make sure the followings
are checked.
npm testto make sure it formats and build successfullyDescription
Because
deltaYis negative when the user is scrolling down, the logic inshouldBeConsumedByChildfor vertical scrolling was flawed.The solution was simply adjusting the
>/<operators to match thedeltaYvalues.