added PID parsing to RFC3164 parser #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guss77
force-pushed
the
feature/rfc3164-pid
branch
from
832a871
to
29474d0
Compare
guss77
force-pushed
the
feature/rfc3164-pid
branch
from
ff8fbec
to
75ceddc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #52.
I'm using a string for the PID as I expect it will just be used to build a string again down the line (also, I'm a go newbie and have no idea how to do
atoi()in go). Also, the default value for a missing PID is the empty string, like a missing tag - that made more sense to me than using0.