fix: defer Promise.reject to avoid unhandled rejection error

Fixes #7
mcous · Jan 10, 2024 · 44a869b · 44a869b
1 parent f83b7a0
commit 44a869b
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 1 deletion.
diff --git a/src/behaviors.ts b/src/behaviors.ts
@@ -25,6 +25,7 @@ export interface BoundBehaviorStack<TReturn> {
 export interface BehaviorEntry<TArgs extends unknown[]> {
   args: TArgs
   returnValue?: unknown
+  rejectError?: unknown
   throwError?: unknown
   doCallback?: AnyFunction | undefined
   times?: number | undefined
@@ -86,7 +87,7 @@ export const createBehaviorStack = <
           ...getBehaviorOptions(values, options).map(({ value, times }) => ({
             args,
             times,
-            returnValue: Promise.reject(value),
+            rejectError: value,
           })),
         )
       },

diff --git a/src/stubs.ts b/src/stubs.ts
@@ -32,6 +32,10 @@ export const configureStub = <TFunc extends AnyFunction>(
       throw behavior.throwError as Error
     }
 
+    if (behavior?.rejectError) {
+      return Promise.reject(behavior.rejectError)
+    }
+
     if (behavior?.doCallback) {
       return behavior.doCallback(...args)
     }

diff --git a/test/vitest-when.test.ts b/test/vitest-when.test.ts
@@ -256,4 +256,12 @@ describe('vitest-when', () => {
 
     expect(spy({ foo: { bar: { baz: 0 } } })).toEqual(100)
   })
+
+  it('should not trigger unhandled rejection warnings when rejection unused', () => {
+    const spy = vi.fn()
+    const error = new Error('uh uhh')
+    subject.when(spy).calledWith('/api/foo').thenReject(error)
+    // intentionally do not call the spy
+    expect(true).toBe(true)
+  })
 })