fix(verifier): do not access out-of-bounds index of calls list (#45)

mcous · Jul 21, 2021 · 15389ad · 15389ad
1 parent b57b111
commit 15389ad
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/decoy/verifier.py b/decoy/verifier.py
@@ -21,7 +21,8 @@ def verify(
         else:
             for i, call in enumerate(calls):
                 calls_subset = calls[i : i + len(rehearsals)]
-                if all(r == calls_subset[j] for j, r in enumerate(rehearsals)):
+
+                if calls_subset == rehearsals:
                     return None
 
         raise VerifyError(

diff --git a/tests/test_verifier.py b/tests/test_verifier.py
@@ -43,6 +43,17 @@ class VerifySpec(NamedTuple):
             SpyCall(spy_id=202, spy_name="spy_202", args=("oh no",), kwargs={}),
         ],
     ),
+    VerifySpec(
+        rehearsals=[
+            VerifyRehearsal(spy_id=101, spy_name="spy_101", args=(1, 2, 3), kwargs={}),
+            VerifyRehearsal(spy_id=101, spy_name="spy_101", args=(4, 5, 6), kwargs={}),
+            VerifyRehearsal(spy_id=202, spy_name="spy_202", args=(7, 8, 9), kwargs={}),
+        ],
+        calls=[
+            SpyCall(spy_id=101, spy_name="spy_101", args=(1, 2, 3), kwargs={}),
+            SpyCall(spy_id=101, spy_name="spy_101", args=(4, 5, 6), kwargs={}),
+        ],
+    ),
     VerifySpec(
         rehearsals=[
             VerifyRehearsal(spy_id=101, spy_name="spy_101", args=(1, 2, 3), kwargs={}),
@@ -76,6 +87,19 @@ class VerifySpec(NamedTuple):
             SpyCall(spy_id=202, spy_name="spy_202", args=(7, 8, 9), kwargs={}),
         ],
     ),
+    VerifySpec(
+        rehearsals=[
+            VerifyRehearsal(spy_id=101, spy_name="spy_101", args=(1, 2, 3), kwargs={}),
+            VerifyRehearsal(spy_id=101, spy_name="spy_101", args=(4, 5, 6), kwargs={}),
+            VerifyRehearsal(spy_id=202, spy_name="spy_202", args=(7, 8, 9), kwargs={}),
+        ],
+        calls=[
+            SpyCall(spy_id=101, spy_name="spy_101", args=(0, 0, 0), kwargs={}),
+            SpyCall(spy_id=101, spy_name="spy_101", args=(1, 2, 3), kwargs={}),
+            SpyCall(spy_id=101, spy_name="spy_101", args=(4, 5, 6), kwargs={}),
+            SpyCall(spy_id=202, spy_name="spy_202", args=(7, 8, 9), kwargs={}),
+        ],
+    ),
     VerifySpec(
         rehearsals=[
             VerifyRehearsal(spy_id=101, spy_name="spy_101", args=(1, 2, 3), kwargs={}),