Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TSP] Move Bind() to Start #28

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

[TSP] Move Bind() to Start #28

wants to merge 17 commits into from

Conversation

mcm001
Copy link
Owner

@mcm001 mcm001 commented Nov 8, 2024

mcm001 and others added 14 commits November 1, 2024 23:50
@mcm001
Assert that version checking won't throw on startup (PhotonVision#1512)
7a4ea3d 
# Overview

Previously if the coproc came up later, getProperty would return the
string literal "null", which made us print the BFW. Add tests to make
sure that we don't do that anymore by rebooting a sim coproc +
robot in a combination of different orders.
@spacey-sooty
Fix typos (PhotonVision#1508)
75e2498 
Signed-off-by: Jade Turner <[email protected]>
@mcm001
Create TSP Server in C++ photonlib (PhotonVision#1516)
fc8ecac 
Automatically starts a TCP server in C++. Also adds warnings to Python.
@crschardt
Add QuadThresholdParameters to AprilTag config (PhotonVision#1519)
625dacb 
This works around a change made to the default QuadThresholdParameters in the WPILib AprilTagDetector for 2025.
wpilibsuite/allwpilib#6847
@Juniormunk
Another config matching bug (PhotonVision#1518)
5d55d21 
This is quite an odd issue/fix. 

So this is what happened... Photonvision booted with the camera
connected and the camera was working...
After a short time the camera stopped working (for some reason maybe
static, maybe temp, maybe wiring, idk).
During this time pv showed

Jul 04 06:25:18 BackLeft java[643]: [2024-07-04 06:25:18] [CSCore -
PvCSCoreLogger] [ERROR] CS: ERROR 40: ioctl VIDIOC_QBUF failed at
UsbCameraImpl.cpp:723: Invalid argument (UsbUtil.cpp:156)
Jul 04 06:25:18 BackLeft java[643]: [2024-07-04 06:25:18] [CSCore -
PvCSCoreLogger] [WARN] CS: WARNING 30: BackLeft: could not queue buffer
0 (UsbCameraImpl.cpp:724)

I went over and played with the wire. The camera fully disconnected but
it ended up "reconnecting"
When the camera was "reconnected" photonvision detected a "new camera"
except this time with no otherpaths (aka no usb path, or by id path).
That resulted in pv creating a new camera configuration for a camera
with no otherpaths
Cscore then started to report errors that look like it attempted to
connect to the same camera twice

This fixes it by filtering out USB cameras that have no otherpath on
linux.
@willtoth
Update docs to specify that WPILib JDK is required on Windows (Photon…
a0b22cd 
…Vision#1522)
@Kouyang07
Fixed Python code block being in C++ block (PhotonVision#1527)
a99a8e7
@mcm001
Create FileLogger JNI (PhotonVision#1517)
8dcf0b3
@mcm001
Fix windows NPEs around exposure+klogs (PhotonVision#1529)
a842581
@crschardt
Make install.sh run the version from photon-image-modifier. (PhotonVi…
58a0597 
…sion#1531)

We've moved the install script to photon-image-modifier. This updates
the install script in photonvision to just download and run the
install.sh from photon-image-modifier.
@LucienMorey
Add missing var to dataclass (PhotonVision#1534)
150561a
@Gold856
Add license to jars (PhotonVision#1530)
04ec99f 
Fixes GPL violation, the license has been missing since 2024.
This also puts licenses in as many JARs and native library archives as possible (for good measure.)
@spacey-sooty
[ci] Fix unamed action steps (PhotonVision#1537)
4cf1c7e
@mcm001
[TSP] Move Bind() to Start
db2ea33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mcm001 @spacey-sooty @crschardt @Juniormunk @willtoth @Kouyang07 @LucienMorey @Gold856