ipmitool to be used with AER only on Ampere Altra platforms

[RocheWilliam]

When monitoring AER errors, verify if we are on an Altra platform
to use ipmitool when dealing with this type of errors.
Needs both --enable-aer and --enable-amp-ns-decode

Fixes: 738bafa ("Add error handling for Ampere-specific errors.")

Signed-off-by: William Roche [email protected]

[RocheWilliam]

The new functionalities added for Ampere platforms with commit 738bafa ("Add error handling for Ampere-specific errors.") introduced 2 problems:

1. The ipmitool command hardcoded with Ampere identifier will be used on any platforms on AER errors as long as rasdaemon is configured with --enable-aer and --enable-amp-ns-decode. Note that by default we configure a build with --enable-all
2. When configured without the --enable-amp-ns-decode, some warnings are generated when compiling about unused 'fn, dev, bus, seg, sel_data and ipmi_add_sel' variables.

The first problem is the most important to solve.

To do so, we introduce an initialization function in the AER code to check if ipmitool should be used (present and on the appropriate platform), this function task is to set a boolean flag indicating if ipmitool needs to be used.
At the time an AER error occurs, ipmitool is used as implemented with 738bafa by @JasonTian518, depending on this flag value.

[RocheWilliam]

Feedback provided by Jason about ras-aer-handler.c changes:

               /* prefer dmidecode as lscpu may not have the necessary dmi info */
               if (stat(DMIDECODE_CMD, &st) == 0)
                              rc = system(DMIDECODE_CMD" -t 4 | /usr/bin/grep "
                                  "'Ampere(R) Altra(R)' > /dev/null");
               else
                              rc = system("/usr/bin/lscpu | /usr/bin/grep "

1. As the lscpu tool only works with patch a772d7c493afcec32f0123fc947013f74db6e45d from https://github.com/karelzak/util-linux.git, suggest to add comments by asking to use newer version than 2.37 or build code by themselves
2. Both dmidecode and lscpu command depends on BIOS implementation(providing CPU information), If customization BIOS didn't provide CPU information or different string, this feature will be disabled, this is the reason why I only set flag during build before now, suggest to add comments to let user know.

---

The new commit "Enrich ras_report_aer_ipmi_init() comments." I just added is a suggestion to address that.

[JasonTian518]

This code can identify different platform from Ampere, I am ok to this change.

[RocheWilliam]

This pull request is still pending, and I'm available to give any detail if needed.
Is there any possible schedule for the integration ? Or could you please let me know if anything is missing in my request ?
Thanks in advance.

[mchehab]

There are a couple of things that require changes. Basically:

• dependencies from command line tools should be set via ./configure;
• don't rely on lscpu/dmidecode/grep - location of such tools are system-dependent and the additional complexity under configure.ac would just make harder to compile it. Instead, just open the needed file(s) from /sys/class/dmi/id/ and/or read the contents of /proc/cpuinfo - seeking for the corresponding CPU model, board name, etc.

[RocheWilliam]

Sorry that it took me so long to come back with an updated version of this fix.
I have updated this pull request by updated my old FixIpmitool_v1 branch with all missing modifications, the last commit:7ca3126 has the differential code.
I also created an updated FixIpmitool_v2 branch in my repository from which I could create a new 'cleaner' pull request if you'd prefer.

Please let me know how you would prefer to proceed with this request ?
Thanks.