New feature: support memory row CE threshold policy

[zhuofeng6]

• Introduction: Identify memory row faults in memory CE faults and isolate the physical memory pages where row faults occur. This method can effectively prevent CE storms or memory UCE faults caused by memory row failures.

• Implementation: The system counts the number of CE faults in the same memory row within a specified period. If the number of CE faults exceeds the configured threshold, the system considers that the memory row may fail and isolates all physical pages recorded in the memory row.

Notes:

1. This function is disabled by default. You can enable it by configuring the'ROW_CE_ACTION' field in the '/etc/sysconfig/rasdaemon' configuration file.
2. If both row isolation and page isolation are enabled, page isolation is automatically disabled by default.
3. If the number of fault times in the DIMM CE fault information received by the rasdaemon is 0, the BIOS does not correctly parse the number of fault times when parsing the fault information. When a fault occurs, the rasdaemon process considers that the number of faults is 1 by default, which is the same as the kernel process.

[mchehab]

Please add a Signed-off-by for the patches you submit.

(please see: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1)

[mchehab]

2. If both row isolation and page isolation are enabled, page isolation is automatically
   disabled by default.

I would be expecting to have a warning for users to know that raw isolation disabled page isolation. Also, I don't see what part of the code actually checks it.

[mchehab]

Nitpick: just one blank line.

[zhuofeng6]

Modified

[mchehab]

Nitpick: please add a blank line after struct definitions.

[zhuofeng6]

Modified

[zhuofeng6]

2. If both row isolation and page isolation are enabled, page isolation is automatically
   disabled by default.

I would be expecting to have a warning for users to know that raw isolation disabled page isolation. Also, I don't see what part of the code actually checks it.

I checked here.

[zhuofeng6]

Please add a Signed-off-by for the patches you submit.

(please see: https://www.kernel.org/doc/html/latest/process/submitting-patches.html#developer-s-certificate-of-origin-1-1)

Already added

[mchehab]

Please rebase on the top of upstream, and check compilation/warnings.

At least here, it is not building with gcc 14.1.1:

In file included from ras-page-isolation.c:24:
ras-page-isolation.h:100:48: warning: comparison between 'enum dsm_location_field_index' and 'enum apei_location_field_index' [-Wenum-compare]
  100 | #define ROW_LOCATION_FIELDS_NUM (DSM_FIELD_NUM > APEI_FIELD_NUM ? DSM_FIELD_NUM : APEI_FIELD_NUM)
      |                                                ^
ras-page-isolation.h:105:49: note: in expansion of macro 'ROW_LOCATION_FIELDS_NUM'
  105 |         int                     location_fields[ROW_LOCATION_FIELDS_NUM];
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~
ras-page-isolation.c: In function 'row_isolation_init':
ras-page-isolation.c:276:9: error: too few arguments to function 'parse_env_string'
  276 |         parse_env_string(&row_threshold, threshold_string);
      |         ^~~~~~~~~~~~~~~~
ras-page-isolation.c:198:13: note: declared here
  198 | static void parse_env_string(struct isolation *config, char *str, unsigned int size)
      |             ^~~~~~~~~~~~~~~~
ras-page-isolation.c:277:9: error: too few arguments to function 'parse_env_string'
  277 |         parse_env_string(&row_cycle, cycle_string);
      |         ^~~~~~~~~~~~~~~~
ras-page-isolation.c:198:13: note: declared here
  198 | static void parse_env_string(struct isolation *config, char *str, unsigned int size)
      |             ^~~~~~~~~~~~~~~~
ras-page-isolation.c: In function 'row_record_copy':
ras-page-isolation.h:100:48: warning: comparison between 'enum dsm_location_field_index' and 'enum apei_location_field_index' [-Wenum-compare]
  100 | #define ROW_LOCATION_FIELDS_NUM (DSM_FIELD_NUM > APEI_FIELD_NUM ? DSM_FIELD_NUM : APEI_FIELD_NUM)
      |                                                ^
ras-page-isolation.c:501:29: note: in expansion of macro 'ROW_LOCATION_FIELDS_NUM'
  501 |         for (int i = 0; i < ROW_LOCATION_FIELDS_NUM; i++) {
      |                             ^~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1256: rasdaemon-ras-page-isolation.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from ras-mc-handler.c:29:
ras-page-isolation.h:100:48: warning: comparison between 'enum dsm_location_field_index' and 'enum apei_location_field_index' [-Wenum-compare]
  100 | #define ROW_LOCATION_FIELDS_NUM (DSM_FIELD_NUM > APEI_FIELD_NUM ? DSM_FIELD_NUM : APEI_FIELD_NUM)
      |                                                ^
ras-page-isolation.h:105:49: note: in expansion of macro 'ROW_LOCATION_FIELDS_NUM'
  105 |         int                     location_fields[ROW_LOCATION_FIELDS_NUM];
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ras-events.c:45:
ras-page-isolation.h:100:48: warning: comparison between 'enum dsm_location_field_index' and 'enum apei_location_field_index' [-Wenum-compare]
  100 | #define ROW_LOCATION_FIELDS_NUM (DSM_FIELD_NUM > APEI_FIELD_NUM ? DSM_FIELD_NUM : APEI_FIELD_NUM)
      |                                                ^
ras-page-isolation.h:105:49: note: in expansion of macro 'ROW_LOCATION_FIELDS_NUM'
  105 |         int                     location_fields[ROW_LOCATION_FIELDS_NUM];
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~

[zhuofeng6]

Please rebase on the top of upstream, and check compilation/warnings.

At least here, it is not building with gcc 14.1.1:

In file included from ras-page-isolation.c:24:
ras-page-isolation.h:100:48: warning: comparison between 'enum dsm_location_field_index' and 'enum apei_location_field_index' [-Wenum-compare]
  100 | #define ROW_LOCATION_FIELDS_NUM (DSM_FIELD_NUM > APEI_FIELD_NUM ? DSM_FIELD_NUM : APEI_FIELD_NUM)
      |                                                ^
ras-page-isolation.h:105:49: note: in expansion of macro 'ROW_LOCATION_FIELDS_NUM'
  105 |         int                     location_fields[ROW_LOCATION_FIELDS_NUM];
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~
ras-page-isolation.c: In function 'row_isolation_init':
ras-page-isolation.c:276:9: error: too few arguments to function 'parse_env_string'
  276 |         parse_env_string(&row_threshold, threshold_string);
      |         ^~~~~~~~~~~~~~~~
ras-page-isolation.c:198:13: note: declared here
  198 | static void parse_env_string(struct isolation *config, char *str, unsigned int size)
      |             ^~~~~~~~~~~~~~~~
ras-page-isolation.c:277:9: error: too few arguments to function 'parse_env_string'
  277 |         parse_env_string(&row_cycle, cycle_string);
      |         ^~~~~~~~~~~~~~~~
ras-page-isolation.c:198:13: note: declared here
  198 | static void parse_env_string(struct isolation *config, char *str, unsigned int size)
      |             ^~~~~~~~~~~~~~~~
ras-page-isolation.c: In function 'row_record_copy':
ras-page-isolation.h:100:48: warning: comparison between 'enum dsm_location_field_index' and 'enum apei_location_field_index' [-Wenum-compare]
  100 | #define ROW_LOCATION_FIELDS_NUM (DSM_FIELD_NUM > APEI_FIELD_NUM ? DSM_FIELD_NUM : APEI_FIELD_NUM)
      |                                                ^
ras-page-isolation.c:501:29: note: in expansion of macro 'ROW_LOCATION_FIELDS_NUM'
  501 |         for (int i = 0; i < ROW_LOCATION_FIELDS_NUM; i++) {
      |                             ^~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [Makefile:1256: rasdaemon-ras-page-isolation.o] Error 1
make[2]: *** Waiting for unfinished jobs....
In file included from ras-mc-handler.c:29:
ras-page-isolation.h:100:48: warning: comparison between 'enum dsm_location_field_index' and 'enum apei_location_field_index' [-Wenum-compare]
  100 | #define ROW_LOCATION_FIELDS_NUM (DSM_FIELD_NUM > APEI_FIELD_NUM ? DSM_FIELD_NUM : APEI_FIELD_NUM)
      |                                                ^
ras-page-isolation.h:105:49: note: in expansion of macro 'ROW_LOCATION_FIELDS_NUM'
  105 |         int                     location_fields[ROW_LOCATION_FIELDS_NUM];
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~
In file included from ras-events.c:45:
ras-page-isolation.h:100:48: warning: comparison between 'enum dsm_location_field_index' and 'enum apei_location_field_index' [-Wenum-compare]
  100 | #define ROW_LOCATION_FIELDS_NUM (DSM_FIELD_NUM > APEI_FIELD_NUM ? DSM_FIELD_NUM : APEI_FIELD_NUM)
      |                                                ^
ras-page-isolation.h:105:49: note: in expansion of macro 'ROW_LOCATION_FIELDS_NUM'
  105 |         int                     location_fields[ROW_LOCATION_FIELDS_NUM];
      |                                                 ^~~~~~~~~~~~~~~~~~~~~~~

Modified