Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade templates to latest version #28

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 13 additions & 11 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -11,18 +11,20 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<jmh.version>1.11.2</jmh.version>
<jmh.version>1.22</jmh.version>
<uberjar.name>benchmarks</uberjar.name>

<pebble.version>2.2.0</pebble.version>
<mustache.version>0.9.1</mustache.version>
<freemarker.version>2.3.23</freemarker.version>
<pebble.version>2.4.0</pebble.version>
ezerk marked this conversation as resolved.
Show resolved Hide resolved
<mustache.version>0.9.6</mustache.version>
<freemarker.version>2.3.29</freemarker.version>
<velocity.version>1.7</velocity.version>
<thymeleaf.version>2.1.4.RELEASE</thymeleaf.version>
<thymeleaf.version>3.0.11.RELEASE</thymeleaf.version>
<junit.version>4.12</junit.version>
<trimou.version>1.8.2.Final</trimou.version>
<hbs.version>4.0.1</hbs.version>
<rocker.version>0.10.3</rocker.version>
<trimou.version>2.5.0.Final</trimou.version>
<hbs.version>4.1.2</hbs.version>
<rocker.version>1.2.2</rocker.version>


</properties>

<licenses>
Expand All @@ -45,10 +47,10 @@
<plugins>
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.1</version>
<version>3.8.1</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
<source>1.8</source>
<target>1.8</target>
</configuration>
</plugin>
<plugin>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public class Freemarker extends BaseBenchmark {

@Setup
public void setup() throws IOException {
Configuration configuration = new Configuration(Configuration.VERSION_2_3_22);
Configuration configuration = new Configuration(Configuration.VERSION_2_3_29);
configuration.setTemplateLoader(new ClassTemplateLoader(getClass(), "/"));
template = configuration.getTemplate("templates/stocks.freemarker.html");
this.context = getContext();
Expand Down
2 changes: 1 addition & 1 deletion src/main/resources/templates/stocks.thymeleaf.html
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ <h1>Stock Prices</h1>
<tbody>
<!--/* Note that itemStat.odd works with index (starting with 0) whereas itemStat.count is starting with 1 */-->
<tr th:each="item: ${items}"
th:class="${itemStat.odd}? 'even' : 'odd'">
th:class="${itemStat.odd}? 'odd' : 'even'">
<td th:utext="${itemStat.count}"></td>
<td><a th:href="${'/stocks/' + item.symbol}"
th:utext="${item.symbol}"></a></td>
Expand Down