New UpsertBulk method moved to the right file.
#1225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @falahati, |
|
If the performance is the same or even better I can't complain. Thank you for informing me. :)
Get Outlook for Android<https://aka.ms/ghei36>
…________________________________
From: Jens Schadron <[email protected]>
Sent: Friday, January 24, 2020 6:30:14 PM
To: mbdavid/LiteDB <[email protected]>
Cc: Soroush <[email protected]>; Mention <[email protected]>
Subject: Re: [mbdavid/LiteDB] New `UpsertBulk` method moved to the right file. (#1225)
Closed #1225<#1225>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#1225?email_source=notifications&email_token=AAS5KDESMMTM6THQLFP4ZRDQ7L675A5CNFSM4HOC4GKKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOWF4W4SI#event-2977525321>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAS5KDBUU7KCWCTMXTPOXYTQ7L675ANCNFSM4HOC4GKA>.
|
|
No problem, I'm still busy creating performance benchmarks using BenchmarkDotNet, but you can keep an eye on the project because they will be here eventually :) |
|
Hi @falahati |
|
I will take a look into this in the coming week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey David,
This was totally my fault in the last PR that you accepted. Unfortunately, I failed to notice that I added the new
UpsertBulkmethod to theInsert.csfiles instead ofUpsert.csfiles. This PR fixes that and hopefully prevent confusion by you and other contributors later when searching for this method.Sorry about that.