Add page-not-found component #30
Open
+167
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
mazid1
requested changes
Jun 28, 2020
There was a problem hiding this comment.
This component will be rendered by angular inside the main index.html page. So, any angular component should not contain DOCTYPE, head, body tags.
| @@ -0,0 +1,39 @@ | |||
| <!DOCTYPE html> | |||
There was a problem hiding this comment.
Please remove DOCTYPE, head and body tags. We only need the specific contents of the component.
| </div> | ||
| <h2>Oops! Nothing was found</h2> | ||
| <p>The page you are looking for might have been removed, had its name changed or is temporarily unavailable.</p> | ||
| <button mat-raised-button>HOME</button> |
There was a problem hiding this comment.
Could you implement redirection to "home" page by clicking this button?
There was a problem hiding this comment.
I've updated the PR as you requested. Please check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.