🔧 [open-zaak/open-zaak#1629] Refactor base settings #17
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 92.24% 92.23% -0.02%
==========================================
Files 54 53 -1
Lines 1148 1043 -105
==========================================
- Hits 1059 962 -97
+ Misses 89 81 -8 ☔ View full report in Codecov by Sentry. |
stevenbal
force-pushed
the
feature/refactor-settings
branch
8 times, most recently
from
f0c314c
to
d370e0b
Compare
and use generic settings from OAF
* add redis * add DISABLE_2FA envvar * add SUBPATH envvar
stevenbal
force-pushed
the
feature/refactor-settings
branch
from
1ab9c4a
to
4ec5b12
Compare
| @@ -12,6 +12,9 @@ services: | |||
| volumes: | |||
| - ./docker-init-db.sql:/docker-entrypoint-initdb.d/init_db.sql | |||
|
|
|||
| redis: | |||
There was a problem hiding this comment.
Please add warning to CHANGELOG that redis is needed now
There was a problem hiding this comment.
And could you also add warning about using 2FA in the CHANGELOG (We use it now, right?)
There was a problem hiding this comment.
@joeribekker Do you think it's needed to add warnings? Afaik there hasn't been an official release of referentielijsten yet
There was a problem hiding this comment.
Adding a warning in the changelog can't hurt though
There was a problem hiding this comment.
added warnings for them
because OAF adds this, but we don't need it here
Partially fixes open-zaak/open-zaak#1629
Changes