Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/63 betrokkene bij klantcontact #75

Closed
wants to merge 3 commits into from

Conversation

bart-maykin
Copy link
Contributor

Fixes #63

Added betrokkene model

@bart-maykin
Copy link
Contributor Author

#62 needs to be merged first.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #75 (ffa4fb4) into master (d481f5f) will increase coverage by 0.16%.
Report is 8 commits behind head on master.
The diff coverage is 98.73%.

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   96.15%   96.31%   +0.16%     
==========================================
  Files          99      108       +9     
  Lines        3508     3745     +237     
==========================================
+ Hits         3373     3607     +234     
- Misses        135      138       +3     
Files Coverage Δ
...rc/openklant/components/klanten/api/serializers.py 85.71% <ø> (ø)
...enklant/components/klanten/api/tests/test_klant.py 100.00% <100.00%> (ø)
...ents/klanten/migrations/0005_auto_20230905_1215.py 100.00% <100.00%> (ø)
src/openklant/components/klanten/models/klanten.py 92.37% <100.00%> (+0.94%) ⬆️
src/openklant/components/klantinteracties/apps.py 100.00% <100.00%> (ø)
...onents/klantinteracties/migrations/0001_initial.py 100.00% <100.00%> (ø)
...s/klantinteracties/migrations/0002_klantcontact.py 100.00% <100.00%> (ø)
...nts/klantinteracties/migrations/0003_betrokkene.py 100.00% <100.00%> (ø)
...ant/components/klantinteracties/models/__init__.py 100.00% <100.00%> (ø)
...nt/components/klantinteracties/models/constants.py 100.00% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bart-maykin bart-maykin force-pushed the feature/63-betrokkene-bij-klantcontact branch 9 times, most recently from 962dd62 to f03b4d5 Compare October 13, 2023 12:25
@bart-maykin bart-maykin force-pushed the feature/63-betrokkene-bij-klantcontact branch 2 times, most recently from 06dda9f to ffa4fb4 Compare October 13, 2023 14:48
@bart-maykin bart-maykin force-pushed the feature/63-betrokkene-bij-klantcontact branch from ffa4fb4 to b21cfec Compare October 17, 2023 12:38
Copy link
Member

@joeribekker joeribekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zelfde algemene punten

verbose_name=_("Klantcontact"),
related_name="betrokkene",
help_text=_("'Klantcontact' had 'Betrokkene bij klantcontact'"),
null=False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
null=False,

niet nodig, is de default :)

)

# Correspondentieadres model fields:
correspondentieadres_nummeraanduiding_id = models.UUIDField(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dit wordt je mixin? Zelfde opmerkingen als bij partij.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Als koploper wil ik een Betrokkene bij klantcontact kunnen registreren
3 participants