✨ [#147] Convenience endpoint for Klantcontact/Betrokkene/Onderwerpobject #260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
previously this used the Klantcontact view, causing incorrect URLs to appear in the detail response for the Onderwerpobject endpoint
stevenbal
force-pushed
the
feature/147-convenience-endpoint
branch
4 times, most recently
from
3d77381
to
4709654
Compare
…ject to allow creation of these three resources in a single API call
stevenbal
force-pushed
the
feature/147-convenience-endpoint
branch
from
4709654
to
d03fd1b
Compare
stevenbal
commented
Oct 3, 2024
| @@ -48,6 +49,11 @@ | |||
| router.register("betrokkenen", BetrokkeneViewSet) | |||
| router.register("onderwerpobjecten", OnderwerpobjectViewSet) | |||
| router.register("bijlagen", BijlageViewSet) | |||
| router.register( | |||
| "klantcontact-convenience", | |||
There was a problem hiding this comment.
not sure how else I could name it without being way too long 😬
|
I had several questions, mostly related to the datamodel itself, because I haven't looked at it before:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
questions:
Onderwerpobject.wasKlantcontactvia convenience endpoint? Why does this field exist in the first place?Onderwerpobject?had_klantcontact/klantcontactandwas_partij/partij?Changes