Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ - refactor: migrate detail process review to BaseListView #399

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

svenvandescheur
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 19.60784% with 82 lines in your changes missing coverage. Please review.

Project coverage is 77.68%. Comparing base (554acf1) to head (e426801).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...ListProcessReview/DestructionListProcessReview.tsx 0.00% 19 Missing and 2 partials ⚠️
...es/destructionlist/hooks/useZaakReviewStatuses.tsx 0.00% 15 Missing and 2 partials ⚠️
...ckend/src/openarchiefbeheer/utils/tests/gherkin.py 6.25% 15 Missing ⚠️
...estructionlist/hooks/useZaakReviewStatusBadges.tsx 0.00% 9 Missing and 2 partials ⚠️
...ctionlist/detail/DestructionListDetail.stories.tsx 0.00% 4 Missing ⚠️
...onents/DestructionListEdit/DestructionListEdit.tsx 0.00% 2 Missing and 1 partial ⚠️
...ntend/src/pages/destructionlist/hooks/useFields.ts 0.00% 0 Missing and 3 partials ⚠️
frontend/src/lib/zaakSelection/zaakSelection.ts 80.00% 1 Missing and 1 partial ⚠️
...rc/pages/destructionlist/abstract/BaseListView.tsx 0.00% 2 Missing ⚠️
...s/destructionlist/review/DestructionListReview.tsx 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #399      +/-   ##
==========================================
+ Coverage   76.39%   77.68%   +1.28%     
==========================================
  Files         245      248       +3     
  Lines        7716     7717       +1     
  Branches      180      170      -10     
==========================================
+ Hits         5895     5995     +100     
+ Misses       1658     1571      -87     
+ Partials      163      151      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@svenvandescheur svenvandescheur marked this pull request as ready for review October 1, 2024 13:30
@svenvandescheur svenvandescheur force-pushed the refactor/process-review branch 2 times, most recently from 666f0f0 to ce401c8 Compare October 1, 2024 14:34
@svenvandescheur svenvandescheur merged commit e59cf42 into main Oct 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants