-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/#94 wachtperiodes #385
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
==========================================
- Coverage 77.32% 76.29% -1.04%
==========================================
Files 240 243 +3
Lines 7463 7682 +219
Branches 158 171 +13
==========================================
+ Hits 5771 5861 +90
- Misses 1545 1664 +119
- Partials 147 157 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comments:
- The status indicator doesn't match the design (should be yellow with a little clock)
- On the detail page I can't see anywhere the planned destruction date.
- Once the planned date has passed, it is not necessarily deleted yet, it will deleted as soon as the worker picks it up. So I think that it is misleading to show "Vernietigd". Not sure what is the most user friendly thing to display here 🤔 Maybe "About to be deleted" or something...?
- I see that in the design the destruction lists without planned destruction date have a "kan vernietigd worden" badge (on the landing page).
- Maybe the modal to plan the deletion should say that it won't be deleted immediately but in 7 days?
- I am missing stories/unit tests/e2e tests (which you think is most appropriate)
frontend/src/pages/destructionlist/detail/DestructionListDetail.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/ProcessingStatusBadge/ProcessingStatusBadge.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/destructionlist/detail/DestructionListDetail.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/ProcessingStatusBadge/ProcessingStatusBadge.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/destructionlist/detail/DestructionListDetail.stories.tsx
Show resolved
Hide resolved
frontend/src/pages/destructionlist/detail/DestructionListDetail.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/destructionlist/detail/DestructionListDetail.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/destructionlist/detail/DestructionListDetail.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/destructionlist/detail/DestructionListDetail.tsx
Outdated
Show resolved
Hide resolved
frontend/src/pages/destructionlist/detail/DestructionListDetail.tsx
Outdated
Show resolved
Hide resolved
|
53f48ba
to
47b5ca4
Compare
Fixes #94