Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/#94 wachtperiodes #385

Merged
merged 4 commits into from
Sep 27, 2024
Merged

Issue/#94 wachtperiodes #385

merged 4 commits into from
Sep 27, 2024

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Sep 24, 2024

Fixes #94

@Xaohs Xaohs marked this pull request as ready for review September 24, 2024 10:54
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 56 lines in your changes missing coverage. Please review.

Project coverage is 76.29%. Comparing base (c85c382) to head (47b5ca4).
Report is 22 commits behind head on main.

Files with missing lines Patch % Lines
...ts/ProcessingStatusBadge/ProcessingStatusBadge.tsx 0.00% 11 Missing and 4 partials ⚠️
...ctionlist/detail/DestructionListDetail.stories.tsx 0.00% 13 Missing ⚠️
...s/destructionlist/detail/DestructionListDetail.tsx 0.00% 12 Missing ⚠️
frontend/src/lib/format/date.ts 46.15% 1 Missing and 6 partials ⚠️
...ructionlist/detail/DestructionListDetail.action.ts 0.00% 6 Missing ⚠️
frontend/src/lib/api/destructionLists.ts 0.00% 1 Missing ⚠️
frontend/src/lib/auth/permissions.ts 50.00% 1 Missing ⚠️
frontend/src/pages/landing/Landing.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #385      +/-   ##
==========================================
- Coverage   77.32%   76.29%   -1.04%     
==========================================
  Files         240      243       +3     
  Lines        7463     7682     +219     
  Branches      158      171      +13     
==========================================
+ Hits         5771     5861      +90     
- Misses       1545     1664     +119     
- Partials      147      157      +10     
Flag Coverage Δ
76.29% <11.11%> (-1.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@SilviaAmAm SilviaAmAm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General comments:

  • The status indicator doesn't match the design (should be yellow with a little clock)
    Screenshot from 2024-09-24 14-29-21
  • On the detail page I can't see anywhere the planned destruction date.
  • Once the planned date has passed, it is not necessarily deleted yet, it will deleted as soon as the worker picks it up. So I think that it is misleading to show "Vernietigd". Not sure what is the most user friendly thing to display here 🤔 Maybe "About to be deleted" or something...?
  • I see that in the design the destruction lists without planned destruction date have a "kan vernietigd worden" badge (on the landing page).
  • Maybe the modal to plan the deletion should say that it won't be deleted immediately but in 7 days?
    Screenshot from 2024-09-24 14-31-46
  • I am missing stories/unit tests/e2e tests (which you think is most appropriate)

frontend/src/fixtures/destructionListItem.ts Outdated Show resolved Hide resolved
frontend/src/fixtures/destructionListItem.ts Outdated Show resolved Hide resolved
frontend/src/lib/format/date.test.ts Outdated Show resolved Hide resolved
frontend/src/lib/format/date.ts Outdated Show resolved Hide resolved
@Xaohs
Copy link
Contributor Author

Xaohs commented Sep 27, 2024

  • On the detail page I can't see anywhere the planned destruction date.
    It should be visible once you have planned it for destruction at the left hand side, see screenshot
  • I see that in the design the destruction lists without planned destruction date have a "kan vernietigd worden" badge (on the landing page).
    Yeah but we've never decided to add this badge in the past either

@Xaohs Xaohs merged commit a37da0b into main Sep 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wachtperiode voor vernietigingsproces
3 participants