Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#378] Prevent crash if reviewItem has zaak = null #379

Merged
merged 4 commits into from
Sep 26, 2024

Conversation

SilviaAmAm
Copy link
Collaborator

@SilviaAmAm SilviaAmAm commented Sep 20, 2024

Fixes #378

@SilviaAmAm SilviaAmAm marked this pull request as draft September 20, 2024 14:52
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 8.62069% with 53 lines in your changes missing coverage. Please review.

Project coverage is 76.52%. Comparing base (1899acd) to head (758c0f3).

Files with missing lines Patch % Lines
...ion/tests/e2e/features/test_feature_list_review.py 9.09% 20 Missing ⚠️
...s/e2e/features/test_feature_list_process_review.py 9.52% 19 Missing ⚠️
...ructionlist/detail/DestructionListDetail.loader.ts 0.00% 2 Missing and 4 partials ⚠️
frontend/src/fixtures/reviewItem.ts 0.00% 4 Missing ⚠️
...ructionlist/review/DestructionListReview.loader.ts 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   76.94%   76.52%   -0.43%     
==========================================
  Files         240      240              
  Lines        7504     7552      +48     
  Branches      158      160       +2     
==========================================
+ Hits         5774     5779       +5     
- Misses       1583     1624      +41     
- Partials      147      149       +2     
Flag Coverage Δ
76.52% <8.62%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SilviaAmAm SilviaAmAm marked this pull request as ready for review September 26, 2024 08:53
@SilviaAmAm SilviaAmAm marked this pull request as draft September 26, 2024 08:53
@SilviaAmAm SilviaAmAm marked this pull request as ready for review September 26, 2024 09:14
@SilviaAmAm SilviaAmAm merged commit 2ea3790 into main Sep 26, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Backend returns null in DestructionListItemReview for the zaak field [Backend/Frontend]
3 participants