♻️ [#390] Remove unused fields frontend

maykinmedia · Oct 1, 2024 · 673b46f · 673b46f
1 parent 89bc829
commit 673b46f
Show file tree

Hide file tree

Showing 7 changed files with 3 additions and 25 deletions.
diff --git a/frontend/src/App.tsx b/frontend/src/App.tsx
@@ -126,9 +126,6 @@ function App() {
                             {user?.firstName} {user?.lastName}
                           </P>
                         </Column>
-                        <Column span={12}>
-                          <P>{user?.role.name}</P>
-                        </Column>
                         <Column span={12}>
                           <P muted>{user?.email}</P>
                         </Column>

diff --git a/frontend/src/fixtures/user.ts b/frontend/src/fixtures/user.ts
@@ -2,11 +2,9 @@ import { Role, User } from "../lib/api/auth";
 import { createArrayFactory, createObjectFactory } from "./factory";
 
 const FIXTURE_ROLE = {
-  name: "Test Role",
   canStartDestruction: false,
   canReviewDestruction: false,
   canReviewFinalList: false,
-  canViewCaseDetails: true,
 };
 export const roleFactory = createObjectFactory<Role>(FIXTURE_ROLE);
 
@@ -26,11 +24,9 @@ const FIXTURE_RECORD_MANAGER: User = {
   lastName: "Manager",
   email: "[email protected]",
   role: {
-    name: "recordmanager",
     canStartDestruction: true,
     canReviewDestruction: false,
     canReviewFinalList: false,
-    canViewCaseDetails: false,
   },
 };
 
@@ -41,11 +37,9 @@ const FIXTURE_BEOORDELAAR: User = {
   lastName: "del Laar",
   email: "[email protected]",
   role: {
-    name: "beoordelaar",
     canStartDestruction: false,
     canReviewDestruction: true,
     canReviewFinalList: false,
-    canViewCaseDetails: false,
   },
 };
 
@@ -56,11 +50,9 @@ const FIXTURE_PROCES_EIGENAAR: User = {
   lastName: "ei Genaar",
   email: "[email protected]",
   role: {
-    name: "proceseigenaar",
     canStartDestruction: false,
     canReviewDestruction: true,
     canReviewFinalList: false,
-    canViewCaseDetails: false,
   },
 };
 

diff --git a/frontend/src/lib/api/auth.ts b/frontend/src/lib/api/auth.ts
@@ -11,11 +11,9 @@ export type User = {
 };
 
 export type Role = {
-  name: string;
   canStartDestruction: boolean;
   canReviewDestruction: boolean;
   canReviewFinalList: boolean;
-  canViewCaseDetails: boolean;
 };
 
 /**

diff --git a/frontend/src/lib/format/user.ts b/frontend/src/lib/format/user.ts
@@ -6,10 +6,7 @@ import { User } from "../api/auth";
  * @param showUsername
  * @param showRole
  */
-export function formatUser(
-  user: User,
-  { showUsername = true, showRole = false } = {},
-) {
+export function formatUser(user: User, { showUsername = true } = {}) {
   if (!user) {
     return "";
   }

diff --git a/frontend/src/pages/destructionlist/create/DestructionListCreate.stories.tsx b/frontend/src/pages/destructionlist/create/DestructionListCreate.stories.tsx
@@ -57,11 +57,9 @@ const meta: Meta<typeof DestructionListCreatePage> = {
           lastName: "Doe",
           email: "[email protected]",
           role: {
-            name: "Admin",
             canStartDestruction: true,
             canReviewDestruction: true,
             canReviewFinalList: false,
-            canViewCaseDetails: true,
           },
         },
       },

diff --git a/...pages/destructionlist/detail/components/DestructionListToolbar/DestructionListToolbar.tsx b/...pages/destructionlist/detail/components/DestructionListToolbar/DestructionListToolbar.tsx
@@ -95,8 +95,7 @@ export function DestructionListToolbar({ title }: DestructionListToolbarProps) {
         <Column span={3}>
           <AttributeTable
             object={{
-              "Laatste review door":
-                review.author && formatUser(review.author, { showRole: true }),
+              "Laatste review door": review.author && formatUser(review.author),
               Opmerking: review.listFeedback,
               Beoordeling: (
                 <Badge level={REVIEW_DECISION_LEVEL_MAPPING[review.decision]}>

diff --git a/frontend/src/pages/landing/Landing.tsx b/frontend/src/pages/landing/Landing.tsx
@@ -166,7 +166,6 @@ export const Landing = () => {
           &nbsp;
           {formatUser(currentAssignee, {
             showUsername: false,
-            showRole: false,
           })}
           {otherAssignees.length && (
             <strong className="LandingPage__assignees-count">
@@ -186,9 +185,7 @@ export const Landing = () => {
         timeAgo: timeAgo(list.created),
         assignees: otherAssignees.length ? (
           <Tooltip
-            content={otherAssignees
-              .map((a) => formatUser(a.user, { showRole: true }))
-              .join(", ")}
+            content={otherAssignees.map((a) => formatUser(a.user)).join(", ")}
             placement="bottom"
           >
             <span>{footer}</span>