Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👷 [#60] Check if envvars have documentation or are excluded from docs #61

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Aug 22, 2024

Currently fails, can be merged once #56 is done

Fixes #60

Changes

  • Check if envvars have documentation or are excluded from docs

@stevenbal stevenbal marked this pull request as draft August 22, 2024 12:05
@stevenbal stevenbal force-pushed the feature/60-ci-check-envvar-help-texts branch 2 times, most recently from 3ae40ae to f0efd33 Compare August 22, 2024 12:10
@stevenbal stevenbal marked this pull request as ready for review August 22, 2024 12:11
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.62%. Comparing base (d9a4a86) to head (2efd209).
Report is 46 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   76.00%   85.62%   +9.62%     
==========================================
  Files           4        8       +4     
  Lines          50      153     +103     
==========================================
+ Hits           38      131      +93     
- Misses         12       22      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal requested a review from Coperh August 23, 2024 08:47
@stevenbal stevenbal force-pushed the feature/60-ci-check-envvar-help-texts branch from f0efd33 to b5364a2 Compare August 23, 2024 08:59
@stevenbal stevenbal force-pushed the feature/60-ci-check-envvar-help-texts branch from 39122fd to 2efd209 Compare August 23, 2024 09:10
Copy link
Contributor

@Coperh Coperh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work correctly

@stevenbal stevenbal merged commit 7f44c50 into main Aug 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check in CI if every envvar either has help_text defined or add_to_docs=False
3 participants