Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [open-zaak/open-zaak#1780] Fix setting NOTIFICATIONS_DISABLED via envvar #452

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

stevenbal
Copy link
Contributor

Fixes open-zaak/open-zaak#1780 partially

Changes

  • Fix setting NOTIFICATIONS_DISABLED via envvar

…nvvar

this setting was defined by OAF, but overridden by a later import from vng_api_common.conf.settings, which hardcoded it to False
Copy link
Collaborator

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change

@annashamray annashamray merged commit 5f74eee into master Sep 24, 2024
14 checks passed
@annashamray annashamray deleted the issue/notifications-disabled-always-false branch September 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong order of settings makes NOTIFICATIONS_DISABLED always False
2 participants