Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Refactor settings module #413

Merged
merged 8 commits into from
Jun 27, 2024
Merged

🔧 Refactor settings module #413

merged 8 commits into from
Jun 27, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Jun 6, 2024 •
edited
Loading

partially fixes open-zaak/open-zaak#1629

Changes

  • Use generic base settings from open api framework

@stevenbal stevenbal marked this pull request as draft June 6, 2024 11:39
@stevenbal stevenbal changed the title 📌 Pin open-api-framework to branch 🔧 Refactor settings module Jun 6, 2024
@stevenbal stevenbal marked this pull request as ready for review June 6, 2024 14:52
@stevenbal stevenbal mentioned this pull request Jun 6, 2024
Closed
9 tasks
Coperh
Coperh reviewed Jun 7, 2024
View reviewed changes
src/objects/conf/base.py Show resolved Hide resolved
src/objects/conf/base.py Show resolved Hide resolved
src/objects/conf/base.py Show resolved Hide resolved
@stevenbal stevenbal marked this pull request as draft June 13, 2024 08:34
@stevenbal stevenbal requested a review from Coperh June 20, 2024 07:53
@stevenbal stevenbal marked this pull request as ready for review June 20, 2024 07:53
annashamray
annashamray approved these changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@annashamray annashamray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat 👍

@stevenbal stevenbal mentioned this pull request Jun 21, 2024
Merged
@stevenbal stevenbal merged commit 2253c12 into master Jun 27, 2024
11 checks passed
@stevenbal stevenbal deleted the feature/refactor-settings branch June 27, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annashamray annashamray annashamray approved these changes

@Coperh Coperh Awaiting requested review from Coperh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As PO I want to streamline all environment variables.
3 participants
@stevenbal @Coperh @annashamray