Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➕ Replace dependencies with open-api-dependencies #358

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

stevenbal
Copy link
Contributor

@stevenbal stevenbal commented Jan 26, 2024

@stevenbal stevenbal marked this pull request as draft January 26, 2024 09:16
@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d24f9d1) 94.89% compared to head (1136644) 94.80%.

Files Patch % Lines
src/objects/utils/autoschema.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #358      +/-   ##
==========================================
- Coverage   94.89%   94.80%   -0.09%     
==========================================
  Files         133      132       -1     
  Lines        4622     4623       +1     
==========================================
- Hits         4386     4383       -3     
- Misses        236      240       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevenbal stevenbal force-pushed the feature/meta-package-deps branch 4 times, most recently from 9c8d972 to 1b09792 Compare January 26, 2024 13:12
@annashamray
Copy link
Collaborator

#357 is merged. Feel free to rebase this PR

@stevenbal stevenbal force-pushed the feature/meta-package-deps branch 17 times, most recently from a8b4979 to 1136644 Compare February 2, 2024 10:31
@stevenbal
Copy link
Contributor Author

stevenbal commented Feb 2, 2024

@joeribekker the kanalen page does not extend another template in the latest version of notifications-api-common, leaving out styling:
image

Before I try to fix this in the library, do we want these kanalen pages to begin with? Because for Open Zaak we switched to links to github at some point: https://github.com/VNG-Realisatie/besluiten-api/blob/develop/src/notificaties.md

Related, the channels aren't actually showing on this page right now: #281

@stevenbal stevenbal changed the title [Draft] ➕ Replace dependencies with open-api-dependencies ➕ Replace dependencies with open-api-dependencies Feb 2, 2024
@stevenbal stevenbal marked this pull request as ready for review February 2, 2024 11:01
@alextreme alextreme removed their request for review February 3, 2024 14:53
@joeribekker
Copy link
Member

Good call Steven but then we need to add those pages to GitHub or docs

@annashamray
Copy link
Collaborator

As discussed on Slack let's:

@stevenbal
Copy link
Contributor Author

@annashamray this PR is ready for review again

@annashamray annashamray merged commit d6bf149 into master Apr 15, 2024
14 checks passed
@annashamray annashamray deleted the feature/meta-package-deps branch April 15, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Open API framework to Objects API
4 participants