Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#315] Display UUID and version of any object type in the admin interface #332

Closed
wants to merge 1 commit into from
Closed

[#315] Display UUID and version of any object type in the admin interface #332

wants to merge 1 commit into from

Conversation

ErhanCitil
Copy link
Contributor

@ErhanCitil ErhanCitil commented May 19, 2023 •
edited
Loading

Fixes #315

@ErhanCitil ErhanCitil linked an issue May 19, 2023 that may be closed by this pull request
As admin I want to see the UUID and version of an objecttype #315
Closed
5 tasks
@joeribekker
Copy link
Member

Make sure your PR description states: Fixes #315 to link the issue properly.

@ErhanCitil ErhanCitil changed the title Display UUID and version of any object type in the admin interface Display UUID and version of any object type in the admin interface, fixes #315 May 19, 2023
@ErhanCitil ErhanCitil requested a review from alextreme May 19, 2023 10:27
@ErhanCitil ErhanCitil self-assigned this May 19, 2023
@ErhanCitil ErhanCitil changed the title Display UUID and version of any object type in the admin interface, fixes #315 [#315] Display UUID and version of any object type in the admin interface May 19, 2023
@alextreme
Copy link
Member

@ErhanCitil sync your PR-branches with master to trigger CI

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2023 •
edited
Loading

Codecov Report

Merging #332 (1630bbc) into master (55fbbee) will decrease coverage by 0.11%.
The diff coverage is 73.91%.

@@            Coverage Diff             @@
##           master     #332      +/-   ##
==========================================
- Coverage   94.78%   94.67%   -0.11%     
==========================================
  Files         131      132       +1     
  Lines        4543     4563      +20     
==========================================
+ Hits         4306     4320      +14     
- Misses        237      243       +6
Impacted Files Coverage Δ
src/objects/accounts/migrations/0001_initial.py 100.00% <ø> (ø)
...cts/accounts/migrations/0002_auto_20201012_1522.py 100.00% <ø> (ø)
...cts/accounts/migrations/0003_auto_20201223_1231.py 100.00% <ø> (ø)
src/objects/api/validators.py 94.02% <ø> (ø)
src/objects/core/migrations/0001_initial.py 100.00% <ø> (ø)
...objects/core/migrations/0002_auto_20200518_1707.py 100.00% <ø> (ø)
src/objects/core/migrations/0003_objectrecord.py 100.00% <ø> (ø)
...bjects/core/migrations/0004_move_data_to_record.py 62.50% <ø> (ø)
...objects/core/migrations/0005_remove_object_data.py 100.00% <ø> (ø)
...objects/core/migrations/0006_auto_20200904_1402.py 100.00% <ø> (ø)
... and 34 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ErhanCitil
Copy link
Contributor Author

@alextreme green

@alextreme
Copy link
Member

Aanpak klopt volgens mij niet helemaal. Er dienen geen ObjectRecord relaties te worden toegevoegd.

In plaats daarvan voeg een veld '_version' toe aan de (gecachede) ObjectType. In de clean methode van de ObjectType dient naast '_name' ook in '_version' de versie van het objecttype opgeslagen te worden.

alextreme
alextreme requested changes Jun 1, 2023
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zie comment

@alextreme
Copy link
Member

@ErhanCitil yubikey lijkt me hier niet in te horen. Ook graag je objectrecord migraties weghalen.

@ErhanCitil ErhanCitil requested a review from alextreme June 6, 2023 14:04
@alextreme
Copy link
Member

@ErhanCitil graag je objectrecord migraties weghalen.

alextreme
alextreme requested changes Jun 6, 2023
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zie migrations 0009 en 0010

@ErhanCitil ErhanCitil requested a review from alextreme June 8, 2023 10:27
@ErhanCitil
Copy link
Contributor Author

@alextreme deze is ready to review

alextreme
alextreme approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@alextreme alextreme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is messy due to the requirements upgrade and blacking of migrations, but the addition of _version seems correct.

@annashamray feel free to do a double-check, if this is not (yet) okay please discuss this with Erhan at the office

joeribekker
joeribekker requested changes Jun 12, 2023
View reviewed changes
Copy link
Member

@joeribekker joeribekker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 meta puntjes:

  1. Kunnen we black pinnen in deze PR om hem zonder veel black wijzigingen akkoord te krijgen?
  2. Deze hele Pr graag in 2 commits: Black pinnen en 315 issue
  3. Nieuwe PR met Black update, pinnen op nieuwe versie en black uitgevoerd op alle bestanden.

@joeribekker
Copy link
Member

Please rebase so only the relevant changes are shown.

@ErhanCitil ErhanCitil force-pushed the feature/uuid-and-version-in-objectype branch 2 times, most recently from 6101b37 to e40065e Compare June 29, 2023 09:16
@ErhanCitil ErhanCitil force-pushed the feature/uuid-and-version-in-objectype branch from e40065e to 1630bbc Compare June 29, 2023 09:21
@ErhanCitil
Copy link
Contributor Author

@joeribekker @alextreme rebase gelukt

@annashamray annashamray removed their request for review May 10, 2024 10:49
@annashamray
Copy link
Collaborator

implemented in #393

@annashamray annashamray closed this Jul 5, 2024
@joeribekker joeribekker deleted the feature/uuid-and-version-in-objectype branch July 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeribekker joeribekker Awaiting requested review from joeribekker

@alextreme alextreme Awaiting requested review from alextreme

Assignees

@ErhanCitil ErhanCitil

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

As admin I want to see the UUID and version of an objecttype
5 participants
@ErhanCitil @joeribekker @alextreme @codecov-commenter @annashamray