Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

11-readme-clean-up #12

Merged
merged 2 commits into from
Dec 23, 2024
Merged

11-readme-clean-up #12

merged 2 commits into from
Dec 23, 2024

Conversation

a6guerre
Copy link
Member

  • Added instructions to build sigfn in README
  • Added instructiosnt to run unit tests in README

@a6guerre a6guerre linked an issue Dec 22, 2024 that may be closed by this pull request
Better Documentation #11
Closed
@a6guerre a6guerre requested a review from johnpatek December 22, 2024 23:25
johnpatek
johnpatek requested changes Dec 22, 2024
View reviewed changes
Copy link
Member

@johnpatek johnpatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am pretty much good with this, but I think we should use ctest instead of calling the executable.

README.md Show resolved Hide resolved
a6guerre and others added 2 commits December 22, 2024 18:12
@johnpatek
11-readme-clean-up
7b47c6b 
* Added instructions to build sigfn in README
* Added instructiosnt to run unit tests in README
@johnpatek
rebased on master
22c5ec4
@codecov Codecov
Copy link

codecov bot commented Dec 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4d7a5a1) to head (22c5ec4).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           48        48           
  Branches         5         5           
=========================================
  Hits            48        48

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johnpatek johnpatek merged commit c9aa57e into master Dec 23, 2024
4 checks passed
@johnpatek johnpatek deleted the 11-readme-cleanup branch December 23, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnpatek johnpatek johnpatek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Better Documentation
2 participants
@a6guerre @johnpatek