Add Proxy Support for Reddit Requests #77
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request implements proxy support for Reddit requests within the ASFFreeGames plugin, addressing issues #75 and #76.
Users can now leverage proxies Reddit.com api specific connections, increasing flexibility for those utilizing proxy servers for Reddit interactions.
Changes:
New configuration options:
ASFFreeGamesOptions.cs
: Added propertiesProxy
andRedditProxy
to support proxy configuration for general and Reddit connections, respectively.ASFFreeGamesOptionsLoader.cs
: Updated to load proxy settings from configuration and environment variables. These settings are then merged to ensure all configurations are considered.Refactored Reddit communication:
GetGames
to utilizeSimpleHttpClientFactory
and itsCreateForReddit
method, enabling the use of the configured Reddit proxy.WebBrowser
usage withSimpleHttpClient
for Reddit communication, allowing proxy support.Benefits:
SimpleHttpClient
consistently.Disclaimers/Bugs/Issues:
System.MissingMethodException
: This change might introduce the possibility of encounteringSystem.MissingMethodException
errors in future ASF updates. Thorough testing and potential code updates may be required to mitigate this risk.Testing:
Additional Notes:
TO-DOs: