Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sveltekit ts project example #46

Merged
merged 11 commits into from
Oct 13, 2023
Merged

feat: add sveltekit ts project example #46

merged 11 commits into from
Oct 13, 2023

Conversation

indaco
Copy link
Contributor

@indaco indaco commented Sep 19, 2023

This PR adds a sample project to showcase how to use maxgraph with SvelteKit

tbouffard
tbouffard reviewed Sep 19, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @indaco thanks for providing this example
I have limited time so I only did a quick review. This looks very promising 💯

I will test it in the few days.
In the meantime, can you check the first comments I already wrote?

projects/sveltekit-ts/pnpm-lock.yaml Outdated Show resolved Hide resolved
projects/sveltekit-ts/src/app.d.ts Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
projects/sveltekit-ts/src/routes/+layout.svelte Outdated Show resolved Hide resolved
projects/sveltekit-ts/src/routes/+page.svelte
let container: HTMLElement;

onMount(async () => {
// Disables the built-in context menu
Copy link
Member

@tbouffard tbouffard Sep 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: the following is duplicated and is not integrating the latest improvements from the ts-example package available in the maxGraph project.
This will be handle with #9 and #41

projects/sveltekit-ts/package.json Show resolved Hide resolved
projects/sveltekit-ts/package.json Outdated Show resolved Hide resolved
tbouffard
tbouffard approved these changes Oct 13, 2023
View reviewed changes
Copy link
Member

@tbouffard tbouffard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this contribution.
I made some minors updates for consistency with other projects.

This PR already covers #41.

@tbouffard tbouffard merged commit 42994e4 into maxGraph:main Oct 13, 2023
13 checks passed
@indaco
Copy link
Contributor Author

indaco commented Oct 13, 2023

@tbouffard thanks for merging

I cannot see the live demo page including it

Is there anything you need for that?

@tbouffard tbouffard added the enhancement New feature or request label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbouffard tbouffard tbouffard approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@indaco @tbouffard