Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: fix ci #480

Merged
merged 10 commits into from
Jun 25, 2024
Merged

build: fix ci #480

merged 10 commits into from
Jun 25, 2024

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Jun 15, 2024 •
edited
Loading

Switch from ubuntu to macos.

Split linting and tests into separate workflows

@setchy setchy changed the title build: fix ci build: fix ci [WIP] Jun 15, 2024
@setchy setchy changed the title build: fix ci [WIP] build: fix ci Jun 15, 2024
@setchy
Copy link
Contributor Author

setchy commented Jun 17, 2024 •
edited
Loading

@amaury1093 - this fixes the broken CI workflow.

There are also a handful of other PRs that I'd appreciate feedback on after this one. 🙏

amaury1093
amaury1093 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@amaury1093 amaury1093 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still no idea why it doesn't work on ubuntu, but this PR is fine for me. Thanks!

@amaury1093 amaury1093 merged commit 36aa4cb into max-mapper:master Jun 25, 2024
2 checks passed
@setchy setchy deleted the fix/ci branch June 25, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amaury1093 amaury1093 amaury1093 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@setchy @amaury1093