Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: widen electron support #473

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

setchy
Copy link
Contributor

@setchy setchy commented Apr 3, 2024

Closes #470

Copy link
Collaborator

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, will merge after the comment below

package.json Show resolved Hide resolved
@amaury1093 amaury1093 merged commit bd3beb2 into max-mapper:master Apr 3, 2024
1 check failed
@mraheelkhan
Copy link

@amaury1093 , it is merged but still not available on npmjs and it still throws this error

npm ERR! Found: [email protected]
npm ERR! node_modules/electron
npm ERR!   dev electron@"^29.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer electron@"^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0 || ^22.0.0 ||  ^23.0.0 || ^24.0.0 || ^25.0.0 || ^26.0.0 || ^27.0.0" from [email protected]

@setchy setchy deleted the feature/bump-electron-support branch May 6, 2024 14:30
@setchy
Copy link
Contributor Author

setchy commented Jun 15, 2024

@amaury1093 , it is merged but still not available on npmjs and it still throws this error

npm ERR! Found: [email protected]
npm ERR! node_modules/electron
npm ERR!   dev electron@"^29.0.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer electron@"^9.0.0 || ^10.0.0 || ^11.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0 || ^15.0.0 || ^16.0.0 || ^17.0.0 || ^18.0.0 || ^19.0.0 || ^20.0.0 || ^21.0.0 || ^22.0.0 ||  ^23.0.0 || ^24.0.0 || ^25.0.0 || ^26.0.0 || ^27.0.0" from [email protected]

i don't believe a new version was published...

@amaury1093
Copy link
Collaborator

v9.5.0 has been published, with support up to 31 (thanks to #476)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add electron 28.x and 29.x support
3 participants