Vehicle: ignore severity of PX4 preflight messages

[MaEtUgR]

Problem

We had someone change this condition out of confusion downstream and I figured out there is no message with emergency severity containing the string "preflight" in the current PX4 version. I can still check if and where they might have existed on older versions but I'd suggest to remove this since for the events it doesn't make sense to sort the text by severity.

Solution

Ignore the severity. I think this was added originally such that emergency messages get output as yellow box and spoken even though they had the word "preflight" in it which usually resulted in a transparent box over the map.

Test Steps

I have not tested the change but went through the existing cases and it shouldn't make a difference with the current version of PX4.

Checklist:

• Check what messages ever fulfilled this condition.

[DonLakeFlyer]

That severity check certainly seems odd. Could you also clean this up such that the two bools first check the firmware type on the vehicle as well. They are firmware specific tests so they should only run on vehicles with that firmware.

So for example:
const bool ardupilotPrearm = apmFirmware() && text.startsWith(QStringLiteral("PreArm"));