Remove qt5compat Module #12081
Open
Remove qt5compat Module #12081
+481
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTRamsey
force-pushed
the
dev-qt5compat
branch
2 times, most recently
from
3fa9dcb to
fab8497
Compare
HTRamsey
force-pushed
the
dev-qt5compat
branch
from
fab8497 to
e985037
Compare
|
@DonLakeFlyer Maybe it's better to just hold on to this until Qt removes the qt5compat module rather than integrate this right now, not sure. |
|
Yeah I agree, it's kind of a bunch of extra cruft to add. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt 2 at this. Since the only reason we needed this lib was for the ColorOverlay, just implement that one element and remove the rest of the module. This prepares for whenever this module is removed entirely (probably closer to Qt7) and also reduces the amount that is downloaded for the build.
Tested and works just like normal