Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the needed dependencies and comments to the docker file #11959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amir-hosseinpour
Copy link

Fix Build Issues and Enhance Dockerfile with Additional Dependencies and Documentation

While attempting to build the original Dockerfile, I encountered several issues that prevented a successful build. To resolve these problems, I have updated the Dockerfile by adding necessary dependencies and providing detailed comments for better clarity and maintainability. Key changes include:

•	Added Dependencies:
•	Installed libinih-dev, fuse, and wget to address missing packages required for the build process.
•	External Libraries:
•	Cloned and built Exiv2, GeographicLib, and zlib from source to ensure compatibility and use the latest versions.
•	Additional Repositories:
•	Integrated ParameterRepository, SDL_GameControllerDB, and PX4-GPSDrivers by cloning their repositories and placing them in the appropriate project directories.
•	Build Enhancements:
•	Built and tested PX4-GPSDrivers to verify proper integration and functionality within the project.
•	Improved Documentation:
•	Added comprehensive comments throughout the Dockerfile to explain each step and configuration, enhancing readability and ease of maintenance.

These updates not only fix the build issues encountered with the original Dockerfile but also streamline the build process, ensure all necessary components are included, and improve the Dockerfile’s overall readability and maintainability.

@HTRamsey
Copy link
Collaborator

We have a CI build that builds via docker just fine right now. Any idea why this was needed for you?

@amir-hosseinpour
Copy link
Author

While I was locally building it, I encountered issues, and tried to edit the docker file.
I'm not sure what caused the issues on my end.
If the CI builds it fine then there is no need for this PR.

@amir-hosseinpour
Copy link
Author

If possible try to do the docker run also, because I was able to build the container but trying to run it and compiling the Codes wasn't successful !

@HTRamsey
Copy link
Collaborator

I'm going to keep this open for now until I can get a chance to look at it closer if you don't mind. I like the added documentation/comments anyways

@HTRamsey HTRamsey reopened this Sep 28, 2024
@amir-hosseinpour
Copy link
Author

Sure, I would love to contribute !
Please let me know if there’s anything else.

@DonLakeFlyer DonLakeFlyer requested a review from HTRamsey December 3, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants