Select language fixes #11667
Merged
Select language fixes #11667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
HTRamsey
reviewed
Jul 9, 2024
This prevent mistakes in the json causing language selection to fail
DonLakeFlyer
force-pushed
the
SelectLanguage
branch
from
f51f486
to
8abfb16
Compare
HTRamsey
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were multiple problem here all star6ing from the fact the we had QLocale::Language ids stored in a json file. This is now set up in code such so that things don't get screwed up. Also added much more validation along the way that the right things are happening.
While testing this I discovered a number of problems with the Chinese json translations where the enum commands which changed to a Chinese char. Hence the string split for them was failing. Luckily most had already been fixed up in Crowdin and I just approved them And then fixed the missing ones.
Closes #11541