Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android: Create Serial Driver Interface #11654

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

HTRamsey
Copy link
Collaborator

@HTRamsey HTRamsey commented Jul 4, 2024

Create interface for accessing android java serial functions. The last step after this is to rebase QSerialPort class to the latest QtSerialPort version

@HTRamsey HTRamsey force-pushed the dev-android-serial-interface branch 21 times, most recently from acbea49 to d14ccb0 Compare July 11, 2024 23:40
@HTRamsey HTRamsey force-pushed the dev-android-serial-interface branch 9 times, most recently from 7802f0f to 19d4660 Compare July 16, 2024 23:10
@HTRamsey HTRamsey force-pushed the dev-android-serial-interface branch 9 times, most recently from 46bc8bf to 3527e37 Compare July 19, 2024 00:33
@HTRamsey HTRamsey marked this pull request as ready for review July 19, 2024 00:35
@DonLakeFlyer
Copy link
Contributor

So what the overall summary to the changes here? Use latest USB support on the Java side of things? Then create a custom QSerialPort which calls into that? How does it differ from the old code?

@HTRamsey
Copy link
Collaborator Author

HTRamsey commented Jul 19, 2024

So I had already updated the Java serial code previously, this just provides a direct cpp interface to the java code in AndroidSerial.cpp and fills in the remaining missing Java functions for QSerialPort cpp functions that weren't implemented (flow control, control lines, break, pinoutsignals, etc). The custom Android QSerialPort already existed, so this just cleans it up to use AndroidSerial.cpp and implements those remaining missing functions.

My comment about rebasing QSerialPort is about updating the QSerialPort and QSerialPort_Android to use the latest QSerialPort from the QtSerialPort module, which is like 8 years newer than the current QSerialPort that this code is based on.

Edit: I removed a few of the unnecessary changes that will be made later when QSerialPort is updated

@HTRamsey HTRamsey force-pushed the dev-android-serial-interface branch 2 times, most recently from 798dc9f to 9d322e6 Compare July 19, 2024 20:41
@HTRamsey HTRamsey force-pushed the dev-android-serial-interface branch from 9d322e6 to fdf4b60 Compare July 24, 2024 21:52
@HTRamsey HTRamsey merged commit 2f18759 into mavlink:master Jul 24, 2024
9 checks passed
@HTRamsey HTRamsey deleted the dev-android-serial-interface branch July 24, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants