Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

camera_def: add note about CAM_MODE param #224

Merged
merged 2 commits into from
Apr 7, 2020
Merged

camera_def: add note about CAM_MODE param #224

merged 2 commits into from
Apr 7, 2020

Conversation

julianoes
Copy link
Contributor

The param CAM_MODE is actually always needed, so we should mention it here.

@julianoes
camera_def: add note about CAM_MODE param
1388a6b 
The param CAM_MODE is actually always needed, so we should mention it
here.
dogmaphobic
dogmaphobic reviewed Apr 7, 2020
View reviewed changes
Copy link
Contributor

@dogmaphobic dogmaphobic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is documented somewhere but being clear about it is never a bad thing.

@hamishwillee
Copy link
Collaborator

This is documented somewhere ...

@dogmaphobic No it isn't. Still waiting on you: #164

I'll merge this, but the docs above are far more comprehensive and need to go in when done.

@hamishwillee hamishwillee merged commit dcbd861 into master Apr 7, 2020
@hamishwillee hamishwillee deleted the pr-camera-mode branch April 7, 2020 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dogmaphobic dogmaphobic dogmaphobic left review comments

@hamishwillee hamishwillee Awaiting requested review from hamishwillee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@julianoes @hamishwillee @dogmaphobic