Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add log information via web api #450

Merged
merged 3 commits into from
Nov 11, 2024
Merged

Add log information via web api #450

merged 3 commits into from
Nov 11, 2024

Conversation

patrickelectric
Copy link
Member

No description provided.

@patrickelectric
Cargo: Add actix-ws and ringbuffer
ae04ece 
Signed-off-by: Patrick José Pereira <[email protected]>
joaoantoniocardoso
joaoantoniocardoso approved these changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't test it today, but the code looks all right!

joaoantoniocardoso
joaoantoniocardoso requested changes Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, it's not working here.

there are a lot of Error receiving message: Lagged(1) on the terminal, and the websocket client only gets the history, not new messages.

I'm testing with websocat -E ws://127.0.0.1:6020/log

joaoantoniocardoso
joaoantoniocardoso reviewed Nov 11, 2024
View reviewed changes
Copy link
Collaborator

@joaoantoniocardoso joaoantoniocardoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found a solution

test_with_five_clients.mp4

src/lib/logger/manager.rs Outdated Show resolved Hide resolved
@patrickelectric patrickelectric merged commit a3f8aae into mavlink:master Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaoantoniocardoso joaoantoniocardoso joaoantoniocardoso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@patrickelectric @joaoantoniocardoso